Skip to content

Added flag to disable check for sketch foldername matching sketch name #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 15, 2021

This is required to ensure backward compatibility for arduino-builder that doesn't enforce this check.

In particular, since arduino-builder is used in the Arduino IDE, if the user tries to compile an unsaved sketch, the Arduino IDE will create a temporary copy of the sketch in a temp dir with a random name: in this case if the folder name check is enabled the compile will fail.

This flag is for internal use only (basically only on arduino-builder) it will be removed once arduino-builder will be completely replaced by arduino-cli in the Arduino IDE.

@cmaglie cmaglie requested a review from silvanocerza February 16, 2021 11:48
@cmaglie cmaglie merged commit 2c7b6ba into arduino:master Feb 16, 2021
@cmaglie cmaglie deleted the relax-sketch-check-flag-for-arduinobuilder branch February 16, 2021 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants